Add initial implementation of Imviz #429

astrofrog · 2021-02-16T17:23:36Z

This is an experimental PR for now and a work in progress, which aims to implement a very simple imviz viewer (one with one viewer and one with two).

EDIT 2 April 2021: Note that this now requires the latest stable release of bqplot-image-gl as well as this branch of glue-jupyter: glue-viz/glue-jupyter#213. Also I've now added a notebook in this PR to demonstrate the features.

Main to-dos:

Figure out how to automatically link the WCSes on data loading - there is infrastructure in glue to do this so it should be a pretty simple call, I can investigate this.
Figure out how to avoid having two configurations, one for one-panel imviz and one for two-panel imviz

(I'll update this list as other things come up)

Ticket tracking

Finish syncing.
Does @astrofrog agree with this?

Fix #513 , fix #515 , fix #517 , fix #522 , fix #523

Partially address #514 (shows the info but not in the desired way), #518, #519, #520

Close https://jira.stsci.edu/browse/JDAT-1192

pllim · 2021-02-19T15:03:15Z

I'll leave my feedback from your first video demo here, for future reference. It was a great demo. Thanks!

Would be nice to have all the commands update the existing window instead of creating new displays, but I understand this is a quick "proof of concept"
For the region, does it support "markers" like "x", "+", or "*" on click? Does region support only cover 2D shapes?
I think we want cursor info outside of the image... though maybe this will be naturally solved if we decide to go down the astrowidgets API via abstract class route... (Initial implementation of abstract class astropy/astrowidgets#126)

pllim · 2021-02-22T15:58:27Z

Note to self: https://gist.github.com/astrofrog/7b8ebb3677ff1f5877c6ae82fc8876ec

astrofrog · 2021-04-02T21:06:04Z

I've now tidied things up a lot following improvements in bqplot-image-gl and glue-jupyter and made the various pieces of functionality into tools or baked in to the imviz viewer directly. The example notebook is included here. Note that this now requires the latest stable release of bqplot-image-gl as well as this branch of glue-jupyter: glue-viz/glue-jupyter#213

@pllim:

Would be nice to have all the commands update the existing window instead of creating new displays, but I understand this is a quick "proof of concept"

Yes I guess the difficulty is that if the notebook is long enough one would need to keep scrolling between reading text and the single viewer, so this keeps each example next to the viewers. Also as it is once all the cells are run you can go and run the different examples whereas with a single viewer you can't do that. I think it's just a matter of preference - if you want to reorganize the notebook to have only one viewer, that's ok too.

For the region, does it support "markers" like "x", "+", or "*" on click?

No but it would be easy to do so I think - for now this section was meant more as a 'joke' in the sense that DS9 used to just add lots of green circles wherever you clicked even if you didn't want it. But we could easily keep track of the regions and have the coordinates accessible to the user, and also have custom markers.

Does region support only cover 2D shapes?

For now yes - at least in the imviz viewer. What use cases are you thinking of?

I think we want cursor info outside of the image... though maybe this will be naturally solved if we decide to go down the astrowidgets API via abstract class route... (astropy/astrowidgets#126)

We can tweak things like this if needed - I'm not sure if astrowidgets would solve this now that we are just going to think of it as an API wrapper. Here I think instead we might want to change the figure margins and move the label down a bit so it falls in the bottom margin.

astrofrog · 2021-04-02T21:09:43Z

I've added a running 'todo' list to the description of this PR.

…-on'

If multiple stack items were present and the first had children but not the requested viewer, then find_viewer_item would incorrectly return None instead of checking the next stack item.

astrofrog · 2021-04-08T11:03:55Z

New demo video based on this PR: https://www.dropbox.com/s/8zc3iox33s5pw7y/imviz_demo_20200408.mov?dl=0

A couple of quick notes:

There is a bug with the panning which I am investigating, but I tried to not make it obvious in the video 😆
There is a bug with the opacity - when the opacity slider is at max, only one layer should be visible (I'll investigate but won't have time to update the video, this is just a disclaimer in case anyone asks)
I don't actually expect users to have to do the manoeuvre with changing the reference data in the second viewer etc - we can make this easier and automatic, but this needs more discussion for now as to how we would like it to behave.

Replace Imviz in old notebook with MyImviz

pllim · 2021-04-08T14:56:22Z

notebooks/ImvizExample.ipynb

+    "import matplotlib.pyplot as plt\n",
+    "\n",
+    "imviz = ImViz()\n",
+    "imviz.load_data('jw01072001001_01101_00001_nrcb1_cal.fits')\n",


Can we replace this with something anyone have access to? Like something in astropy-data or STScI Box URL thingy?

Done, for now just using data from data.astropy.org and later we could switch to JWST simulated (or actual eventually!) data

Update to PR 429

pllim · 2021-04-08T18:54:03Z

Re: #429 (comment)

I was told by POs that 1D shape isn't a priority right now, so you can ignore me there and stick to 2D regions.

pllim · 2021-04-13T18:08:57Z

Also see astrofrog#2

pllim · 2021-04-13T20:29:12Z

Note to self: This blocks https://jira.stsci.edu/browse/JDAT-1406

Update dependencies for Imviz

…enabling WCS matching

astrofrog · 2021-04-15T11:01:35Z

I've now updated this PR so that the auto-linking happens when the 'match WCS' button is clicked which I think is reasonable. So I think in the interest of moving forward, if the CI passes this can probably be merged and we can open follow-up issues and PRs for your comments @pllim? (merging now means we can then split up the work for the rest)

pllim · 2021-04-15T16:18:30Z

@astrofrog , I opened some follow-up issues and assigned to you those you explicitly said you were going to investigate. FYI.

astrofrog marked this pull request as draft February 16, 2021 17:23

pllim mentioned this pull request Mar 2, 2021

Widget should not inherit from VBox astropy/astrowidgets#132

Closed

pllim mentioned this pull request Mar 31, 2021

Expand imviz proof of concepts #496

Closed

3 tasks

astrofrog force-pushed the imviz branch from 8d1b92f to 5f8d9fc Compare April 2, 2021 20:56

astrofrog mentioned this pull request Apr 2, 2021

Start implementing 'always-on' MouseInteraction glue-viz/glue-jupyter#213

Merged

astrofrog added 9 commits April 8, 2021 09:54

Added imviz proof of concepts

6534768

Add coordinate overlay tool

c610120

Simplify imviz tools, make coordinate overlay and blinking be 'always…

1a11a8e

…-on'

Added ImViz example notebook

002a3d3

Fix code style issues

cd95982

Fixed tests

82690d9

Fixed long line

be7e22e

Enable CLI usage and add a new tool to create a new image viewer

9deec9d

Fix code style

2bc9b1a

astrofrog force-pushed the imviz branch from 876c71e to 2bc9b1a Compare April 8, 2021 08:54

astrofrog added 7 commits April 8, 2021 10:16

Fixed bug in _viewer_item_by_id

4f7c140

If multiple stack items were present and the first had children but not the requested viewer, then find_viewer_item would incorrectly return None instead of checking the next stack item.

Improve error message if a viewer is not found

bb4d2e4

Removed leftover debug statement

e738659

Remove hard-coded 2-panel imviz

8f84269

Add WCS auto-linking of datasets

169ccbd

Updated ImVizExample notebook

3c70835

Be specific about which events we need

8bf8075

pllim added the imviz label Apr 8, 2021

Branding: Use Imviz, not ImViz.

523d2f1

Replace Imviz in old notebook with MyImviz

pllim reviewed Apr 8, 2021

View reviewed changes

pllim added this to the Imviz 1.0 milestone Apr 8, 2021

Merge pull request #1 from pllim/pr429

87a8d99

Update to PR 429

This was referenced Apr 13, 2021

WIP: Imviz with only Glue + bqplot #417

Closed

imviz-round-1.5 (astrowidgets + Glupyter) #445

Closed

Update deps for Imviz

f6c14c7

pllim mentioned this pull request Apr 13, 2021

Update dependencies for Imviz astrofrog/jdaviz#2

Merged

astrofrog added 2 commits April 13, 2021 23:01

Merge pull request #2 from pllim/pr429

82ee520

Update dependencies for Imviz

Fix bugs with mouseover coordinates and only auto-link datasets when …

8eb022f

…enabling WCS matching

astrofrog changed the title ~~EXP: Added imviz proof of concepts~~ Add initial implementation of Imviz Apr 15, 2021

astrofrog marked this pull request as ready for review April 15, 2021 10:51

astrofrog requested review from duytnguyendtn, ibusko, javerbukh and rosteen as code owners April 15, 2021 10:51

Updated notebook to use remote datasets

afc59b9

Enable tabs in imviz

09a1abd

astrofrog requested a review from pllim April 15, 2021 11:05

pllim merged commit 28557a0 into spacetelescope:main Apr 15, 2021

This was referenced Apr 15, 2021

MNT: Stop relying on dev glue-jupyter #533

Closed

BUG: Imviz panning #534

Closed

BUG: Imviz opacity #535

Closed

ENH: Imviz "maneuvers" #536

Closed

JDAT-1222: Blinking/tabbing between images #520

Closed

This was referenced Apr 16, 2021

BUG: Blank image in Linux Chromium #540

Closed

MNT: Ignore FITS from version control #559

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add initial implementation of Imviz #429

Add initial implementation of Imviz #429

astrofrog commented Feb 16, 2021 •

edited

Loading

pllim commented Feb 19, 2021 •

edited

Loading

pllim commented Feb 22, 2021

astrofrog commented Apr 2, 2021

astrofrog commented Apr 2, 2021

astrofrog commented Apr 8, 2021 •

edited

Loading

pllim Apr 8, 2021

astrofrog Apr 15, 2021

pllim commented Apr 8, 2021

pllim commented Apr 13, 2021

pllim commented Apr 13, 2021

astrofrog commented Apr 15, 2021 •

edited

Loading

pllim commented Apr 15, 2021

Add initial implementation of Imviz #429

Add initial implementation of Imviz #429

Conversation

astrofrog commented Feb 16, 2021 • edited Loading

Ticket tracking

pllim commented Feb 19, 2021 • edited Loading

pllim commented Feb 22, 2021

astrofrog commented Apr 2, 2021

astrofrog commented Apr 2, 2021

astrofrog commented Apr 8, 2021 • edited Loading

pllim Apr 8, 2021

Choose a reason for hiding this comment

astrofrog Apr 15, 2021

Choose a reason for hiding this comment

pllim commented Apr 8, 2021

pllim commented Apr 13, 2021

pllim commented Apr 13, 2021

astrofrog commented Apr 15, 2021 • edited Loading

pllim commented Apr 15, 2021

astrofrog commented Feb 16, 2021 •

edited

Loading

pllim commented Feb 19, 2021 •

edited

Loading

astrofrog commented Apr 8, 2021 •

edited

Loading

astrofrog commented Apr 15, 2021 •

edited

Loading